yugabyte/yugabyte-db

[DocDB] Expand events for slow disk access to all reads and writes

Open

#16,828 opened on Apr 12, 2023

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C (1,003 forks)batch import
area/docdbgood first issuekind/enhancementpriority/medium

Repository metrics

Stars
 (8,229 stars)
PR merge metrics
 (Avg merge 17d 21h) (92 merged PRs in 30d)

Description

Jira Link: DB-6178

Description

Related to #16827, we could then also add special logging, for "too slow" events, across all IO! This could be similar to how we have "slow fsync" events, at the WAL level...

If we had proper metrics at the lower level, of the env disk access abstraction, we should be able to push down even the slow fsync event, from the log.cc level.

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.

Contributor guide

Research direction
Examine the existing slow fsync event implementation in log.cc and the Env disk access abstraction. Propose a way to expand metrics to all reads and writes, possibly by adding hooks at the lower level. Implement the change and ensure backward compatibility.
Tech stack
cppsql
Domain
databasebackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Database internalsLinux I/O
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30