yugabyte/yugabyte-db

[yb-admin] ysql_catalog_version always returns 0

Open

#11,096 opened on Jan 14, 2022

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C (1,003 forks)batch import
area/documentationgood first issuehelp wantedkind/bugstatus/awaiting-triagetemp/docs-migration

Repository metrics

Stars
 (8,229 stars)
PR merge metrics
 (Avg merge 17d 21h) (92 merged PRs in 30d)

Description

On recent versions, yb-admin ysql_catalog_version keeps returning zero even after catalog changes. This is because it uses CatalogManager::GetYsqlCatalogConfig which reads from the legacy protobuf catalog version, not the pg_yb_catalog_version system table. Fix yb-admin to get the version from the correct source.

Contributor guide

Research direction
The bug is that yb admin uses CatalogManager::GetYsqlCatalogConfig which reads from the legacy protobuf catalog version, but the correct source is the pg yb catalog version system table. To fix, modify the yb admin code to query that table instead. Look at how YSQL upgrade code retrieves the catalog version for reference.
Tech stack
cppsqlpostgresql
Domain
backenddatabase
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++PostgreSQL internalsSQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50