Repository metrics
- Stars
- (556 stars)
- PR merge metrics
- (PR metrics pending)
Description
Originally reported by: Chris Malone (Bitbucket: ChrisMalone, GitHub: ChrisMalone)
This came up in the comments of a PR. In essence, @mzingale summarized the issue quite well:
"I'm a little concerned about the name thermal energy. We don't necessarily have thermal energy easily available [in Maestro]. We have internal energy, or gas energy, but when we are very degenerate, the internal energy is not thermal, so the name thermal energy is misleading and perhaps dangerous. Since this is a yt convention, maybe for these codes we should return an error if thermal energy is requested and perhaps we can define a more code-agnostic general name for the gas internal energy that can be used in situations where thermal energy is wrong."
Another place this crops up is in calculations of the sound speed, where \gamma might be assumed spatially constant.