yt-project/yt

Handling cell_volume in 1D and 2D cartesian

Open

#797 opened on Mar 5, 2014

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (315 forks)auto 404
help wantedwishlist

Repository metrics

Stars
 (556 stars)
PR merge metrics
 (PR metrics pending)

Description

Originally reported by: John ZuHone (Bitbucket: jzuhone, GitHub: jzuhone)

cell_volume is ill-defined for 1D and 2D cartesian data because it is still given in terms of length**3, even though the unused dimensions are meaningless. What we have done is set the domain_width to unity in these cases, but with the unit refactor I think this issue ought to be revisited.

That said, I'm not sure what to do about it.

Contributor guide

Research direction
Examine the cell volume implementation in yt for 1D and 2D cartesian geometries, and determine how to adjust the volume calculation to handle unused dimensions appropriately, possibly by setting domain width to unity in those dimensions. Consider the implications of the unit refactor.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70