yt-project/yt

Callbacks for OffAxisSlicePlot and OffAxisProjectionPlot

Open

#486 opened on Jan 12, 2013

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (315 forks)auto 404
enhancementhelp wantedviz: 2Dwishlist

Repository metrics

Stars
 (556 stars)
PR merge metrics
 (PR metrics pending)

Description

Originally reported by: Nathan Goldbaum (Bitbucket: ngoldbaum, GitHub: ngoldbaum)

A number of callbacks don't work using OffAxisProjectionPlot. This is mostly because OffAxisProjectionPlot is a bit of a hack, as it wraps the volume render and camera by creating a dummy data object that doesn't inherit from AMRData. In principle we should be able to get the callbacks working either by substituting alternate forms that work for off-axis data, generalizing the callback to accept both axis-aligned and off-axis data, and disabling callbacks that don't make sense for off axis data. We'll also have to think about how to do this in a forward-compatible way (if we want to include OffAxisProjectionPlot in 2.5, we didn't include it in 2.4).

Currently nonfunctional callbacks are disabled. This issue can be closed once all of the callbacks work correctly when fed off-axis data.

Contributor guide

Research direction
Examine the OffAxisProjectionPlot class and identify which callbacks are nonfunctional. Understand how callbacks interact with the data object and camera setup. For each callback, determine if it can be adapted to work with off axis data or needs an alternative implementation. Implement fixes or disable callbacks that cannot be made to work, ensuring forward compatibility.
Tech stack
python
Domain
data
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50