yt-project/yt

Re-enable healpix interface in yt after resolving licensing concerns

Open

#1,048 opened on Jul 23, 2015

View on GitHub
 (3 comments) (0 reactions) (1 assignee)Python (315 forks)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (556 stars)
PR merge metrics
 (PR metrics pending)

Description

Originally reported by: Bili Dong (Bitbucket: qobilidop, GitHub: qobilidop)

In grid_traversal.pyx the following 10 functions will raise a NotImplementedError no matter what:

  • hp_pix2vec_nest
  • arr_pix2vec_nest
  • hp_vec2pix_nest
  • arr_vec2pix_nest
  • hp_pix2ang_nest
  • arr_pix2ang_nest
  • hp_ang2pix_nest
  • arr_ang2pix_nest
  • pixelize_healpix
  • healpix_aitoff_proj

Based on the discussion in Issue #1047, this is because their common dependency healpix_interface was removed for licensing concerns. I've only seen those functions being used in the module /yt/visualization/volume_rendering/camera.py. So I guess either those functions should be fixed, or camera.py should be rewritten.

If my understanding is correct, the module yt/utilities/lib/healpix_interface.pxd should also be removed, right?

Contributor guide

Research direction
Investigate the licensing concerns that led to the removal of healpix interface and explore alternative implementations or re enabling with proper licensing.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60