yt-project/yt

Set buff size based on aspect ratio, dpi, and window size

Open

#1,021 opened on May 11, 2015

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (315 forks)auto 404
enhancementhelp wantednew contributor friendlywishlist

Repository metrics

Stars
 (556 stars)
PR merge metrics
 (PR metrics pending)

Description

Originally reported by: Matt Turk (Bitbucket: MatthewTurk, GitHub: MatthewTurk)

Right now, it seems like our buff_size is always set identically to (800,800) in SlicePlot and the like.

This can be overcome by doing a set_buff_size call, but this call is also somewhat counterintuitive, as it is in reverse order (height, width). I think, but am not certain, that we can get desired behavior by setting buff_size to None in the constructor, and then inside _setup_plots (where we'll have the aspect ratio info as well as the figure size, although we should probably assume 100 or 300 DPI) we can guess the buffer size.

(Thanks to @maxhutch for the pointer on this.)

Contributor guide

Research direction
Investigate how `buff size` is currently set in `SlicePlot` and ` setup plots`. Modify the constructor to set `buff size=None` initially. In ` setup plots`, compute the buffer size using the figure size, DPI (default 100 or 300), and aspect ratio from the plot. Ensure the order is (width, height) consistent with `set buff size` documentation. Test with various window sizes and DPI settings.
Tech stack
python
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonyt
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50