you-dont-need/You-Dont-Need-Lodash-Underscore

Add more suggestions for _.first

Open

#312 opened on May 2, 2021

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (18,379 stars) (811 forks)batch import
enhancementhelp wanted

Description

Currently, the suggestion we get for _.first might not be relevant in all cases. Array.prototype.slice() returns an array. But _.first from lodash returns a non-array value. So this line should be something like this I guess:

"alternative": "Array.prototype.slice() or arr[0]"

Also, I think we should add more aliases here. For example _.head should be prevented when _.first is prevented, because they're basically the same.

Contributor guide

Tech stack
javascript
Domain
documentation
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptJSON formatfamiliarity with lodash
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Locate the file lib/rules/rules.json at line 51. Modify the alternative field for .first to include 'arr[0]' in addition to Array.prototype.slice(). Also add aliases like .head to be prevented when .first is prevented. Check existing pattern for adding aliases in the rules file.