you-dont-need/You-Dont-Need-JavaScript

Click on button for modal scrolls page to top

Open

#10 opened on Jul 5, 2016

View on GitHub
 (10 comments) (0 reactions) (1 assignee)HTML (20,530 stars) (1,496 forks)batch import
PR Welcomehelp wanted

Description

In the modal example, when you click on the button to show the modal, the modal shows but the page also scrolls to the top. This would end up as a bug in our backlog :)

Contributor guide

Tech stack
htmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic HTML and CSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is that clicking a button to open a modal also causes the page to scroll to the top. This is likely due to the default behavior of anchor links or button events. To fix, investigate the modal trigger implementation, perhaps using event.preventDefault() or changing the href attribute. Look at the modal component code in the repository, possibly in the examples folder. The existing comments may provide more context.