yogthos/memory-hole

event handlers are not pure

Open

#22 opened on Oct 29, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Clojure (25 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (264 stars)
PR merge metrics
 (PR metrics pending)

Description

Event handlers in re-frame should be pure. In the handlers there are side effects created by calling ajax functions.

https://github.com/yogthos/memory-hole/blob/master/src/cljs/memory_hole/handlers/admin.cljs#L15

The re-frame / pure way would be to write an effect handler which handles the execution of the state change. Have a look at the following library to see how this can be solved in a pure way:

https://github.com/Day8/re-frame-http-fx

Contributor guide

Research direction
Review the re frame http fx library and refactor the admin handlers to use effect handlers for ajax calls.
Tech stack
clojure
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Clojurere frame
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60