yogthos/markdown-clj

Feature request: Add support for link (and image) attributes

Open

#134 opened on Apr 13, 2017

View on GitHub
 (0 comments) (1 reaction) (0 assignees)Clojure (120 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (570 stars)
PR merge metrics
 (PR metrics pending)

Description

With issues #116 and #128 going in, we'll have support for titles on links. But there are times when I need to add other attributes such as class, rel and others to links. I know the original markdown syntax doesn't support something like this, but without it, I'm forced to drop down to writing literal HTML for links in most cases. The same is true for images as I want to add the class attribute for them.

I'm proposing the following. It's not my idea, but I like how little it impacts the markdown syntax in terms of aesthetics and readability.

This is a formatted ![penguin_image][] image and a [penguin_link][] link with attributes.

[penguin_image]: http://foo.com/penguin.jpg "penguin" class="img-responsive center-block"
[penguin_link]: http://foo.com/penguin.html "Penguins" rel="external nofollow"
                style="color: red;"

Contributor guide

Research direction
Examine the current markdown parser for link and image syntax, then add support for attributes after the link title using a key=value format.
Tech stack
clojure
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Clojure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70