yogthos/Selmer

using `include` - java.io.FileNotFoundException: [projectpath]/src (Is a directory)

Open

#79 opened on Apr 23, 2015

View on GitHub
 (11 comments) (0 reactions) (0 assignees)Clojure (670 stars) (86 forks)batch import
enhancementhelp wanted

Description

selmer v0.8.2

General project layout:

[projectpath]/project.clj
[projectpath]/src/...
[projectpath]/templates/layouts/main.html
[projectpath]/templates/includes/footer.html

Declared in proect.clj: :resource-paths ["public" "resources" "templates"]

This works:

(selmer.parser/render-file "layouts/main.html")

However when adding {% include "includes/footer.html" %} to main.html, this error is thrown:

java.io.FileNotFoundException: [projectpath]/src (Is a directory)
                   (Unknown Source) java.io.FileInputStream.open0
           FileInputStream.java:195 java.io.FileInputStream.open
           FileInputStream.java:138 java.io.FileInputStream.<init>
                         io.clj:238 clojure.java.io/fn
                          io.clj:69 clojure.java.io/fn[fn]
                         io.clj:165 clojure.java.io/fn
                          io.clj:69 clojure.java.io/fn[fn]
                         io.clj:102 clojure.java.io/reader
                    RestFn.java:410 clojure.lang.RestFn.invoke
                  validator.clj:103 selmer.validator/validate-tags
                  validator.clj:116 selmer.validator/validate
            template_parser.clj:196 selmer.template-parser/read-template
            template_parser.clj:252 selmer.template-parser/preprocess-template
                    RestFn.java:439 clojure.lang.RestFn.invoke
             template_parser.clj:51 selmer.template-parser/insert-includes[fn]
             template_parser.clj:41 selmer.template-parser/insert-includes
            template_parser.clj:252 selmer.template-parser/preprocess-template
                    RestFn.java:410 clojure.lang.RestFn.invoke
                     parser.clj:236 selmer.parser/parse-file
                     parser.clj:262 selmer.parser/parse
                    RestFn.java:442 clojure.lang.RestFn.invoke
                     parser.clj:122 selmer.parser/render-file

Contributor guide

Tech stack
None
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The bug occurs when using the `{% include %}` tag in a template that is within a directory path listed in `:resource paths`. The error suggests that the insertion process is incorrectly trying to open the `src` directory as a file. Investigate the `insert includes` function in `selmer.template parser` (likely around line 41-51) and the `read template` function to understand how include paths are resolved relative to resource paths. Also examine `validator.clj` around line 103 for the `validate tags` function. Look at the comments in the issue for any clues or proposed solutions. Consider testing with a minimal reproduction to identify the logic flaw.