yogthos/Selmer

No boolean operators for conditions

Open

#311 opened on Oct 25, 2024

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Clojure (670 stars) (86 forks)batch import
enhancementhelp wanted

Description

I know there is "all" and "any" in conditions, but there doesn't seem to be an "and" (or "or") operator for instance?

Like: {% if condition-a and condition-b %} (or perhaps "if and conditon-a condition-b")

Right now I need to nest two if-tags, which is not so nice..

Contributor guide

Tech stack
None
Domain
full stack
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Clojure programmingUnderstanding of Selmer template syntax
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review the Selmer parser implementation, likely in src/selmer/parser.clj, to understand how conditions like `all` and `any` are currently handled. Look for the condition parsing logic and consider adding `and` and `or` operators by extending the parser and the corresponding execution paths. Check if there are any test files for conditions to guide the implementation and ensure backward compatibility.