yogthos/Selmer

Missing filter custom handling

Open

#307 opened on Jan 23, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Clojure (670 stars) (86 forks)batch import
enhancementhelp wanted

Description

Hello,

I was wondering if you'd ever consider adding support for overriding the behavior when a non-existent filter is used in the template string.

Currently if the filter is not found an exception is thrown (relevant code). Our company would like the ability to override this behavior.

Current: (render "{{a | nonExistentFilter}}" {:a 1}) => Throws Exception: No filter defined with the name nonExistentFilter

Desired (for my use case): (render "{{a | nonExistentFilter}}" {:a 1}) => "{{a | nonExistentFilter}}" no thrown exceptions.

I was thinking this would be similar to the work done in #130 where we'd allow users to override a var that would default to the existing behavior.

I'd be open to submitting a PR for this and have a proof of concept of the functionality.

Thanks!

Contributor guide

Tech stack
None
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic Clojure knowledgeUnderstanding of Selmer's filter system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Look at the filter parser.clj file (line 99) where the exception is thrown. Study the approach used in the referenced PR #130 for customizing behavior. Implement a similar mechanism to allow users to override the var that handles missing filters, defaulting to the current exception throwing behavior.