yogthos/Selmer

known-variables and tags

Open

#306 opened on Oct 6, 2023

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Clojure (121 forks)batch import
bughelp wanted

Repository metrics

Stars
 (1,042 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

It seems that #'parser/known-variables does not handle variables in tags correctly:

user=> (selmer/known-variables "{% if {{var}} %}{{other-var}}{% endif %}")
#{:other-var :{{var}}}
;; expected:
;; #{:other-var :var}

Contributor guide

Research direction
Examine the `known variables` function in the Selmer parser to see how it handles nested template tags like `{% if {{var}} %}`, and adjust the logic to extract inner variables correctly.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitClojure basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80