yogthos/Selmer

Minify HTML before caching

Open

#221 opened on Apr 9, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Clojure (670 stars) (86 forks)batch import
enhancementhelp wanted

Description

Is it possible to hook up a minifier before caching the template?

I was looking at gluing Selmer and this: https://github.com/yogthos/asset-minifier (more specifically this) but it seems that I would have to run the minifcation on top of Selmer's already cached content?

The thing I am trying to avoid is having to cache twice, or having to run minifcation on requests themselves.

Or should I manually minify the template itself after each edit?

(did I say minify enough times?)

Contributor guide

Tech stack
None
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding Selmer cachingFamiliarity with Clojure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The issue requests hooking up a minifier before caching templates. The creator suggests using asset minifier or clj html compressor. To implement, examine Selmer's caching logic in its source code (likely in the cache namespace). Look at how templates are cached and where minification could be inserted. No linked PRs exist, so a solution would need to design a hook or configuration option. The maintainer has not responded, so a proposed implementation should be self contained.