yogthos/Selmer

String keys in for loops

Open

#133 opened on Oct 5, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Clojure (670 stars) (86 forks)batch import
enhancementhelp wanted

Description

Related to #54 I am trying to do something similar with a for loop.

As an example if the for variable is a keyword this works

(render "{% for a in Amt %}{{a.attr.Ccy}}{{a.content.0}} {% endfor %}" 
    {:Amt [{:attr {"Ccy" "USD"}, :content ["0.010000000"]} 
           {:attr {"Ccy" "GBP"}, :content ["0.020000000"]}]})
 => "USD0.010000000 GBP0.020000000 "

However changing :Amt to "Amt" produces nothing

 (render "{% for a in Amt %}{{a.attr.Ccy}}{{a.content.0}} {% endfor %}" 
    {"Amt" [{:attr {"Ccy" "USD"}, :content ["0.010000000"]} 
            {:attr {"Ccy" "GBP"}, :content ["0.020000000"]}]})
=> ""

Should this be added as an enhancement to make processing consistent?

Contributor guide

Tech stack
None
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic Clojure knowledgeUnderstanding of template variable lookup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Locate the code handling variable resolution in for loops, likely in the parser (e.g., `src/selmer/parser.clj`). Investigate how the for loop variable name is used to access the context map. The current behavior works with keywords but not strings. Determine if the fix involves converting string keys to keywords or adding a fallback lookup. See linked issue #54 for related context.