ykyouhei/KYDrawerController

Won't work if set "drawerViewControlller" first by Code.

Open

#99 opened on Jul 20, 2017

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Swift (156 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (619 stars)
PR merge metrics
 (PR metrics pending)

Description

I am sure that if set "drawerViewControlller" before "mainViewController", it will not work. Just try in the "Code" Example by simply reordering setting sequence of "drawerViewControlller" and "mainViewController" in AppDelegate.

It confused me a lot and took me a lot time to debug that. I am still not sure whether it's because "addChildController" sequence/order.

I would be grateful if someone can confirm me the real reason.

Contributor guide

Research direction
Examine the order of setting drawerViewController and mainViewController; ensure drawerViewController is set after mainViewController or adjust the child controller addition order.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Swift
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70