ykyouhei/KYDrawerController

On first display, drawer controller animates vertically

Open

#61 opened on Aug 10, 2016

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Swift (156 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (619 stars)
PR merge metrics
 (PR metrics pending)

Description

On first run of

drawerController.setDrawerState(KYDrawerController.DrawerState.Opened, animated: true)

to open the drawer, the drawer view controller has a slight vertical animation. Presumably, this is from a CGRectZero frame or something similar. Calls to drawerController.drawerViewController?.loadView() or drawerController.drawerViewController?.view.layoutIfNeeded() before display have no effect.

Current workaround is to open and close the drawer without an animation after application has finished launching.

drawerController.setDrawerState(KYDrawerController.DrawerState.Opened, animated: false)
drawerController.setDrawerState(KYDrawerController.DrawerState.Closed, animated: false)

but creates warnings in the debugger

Unbalanced calls to begin/end appearance transitions for <UIViewController: 0x7ff262ed9870>.
Unbalanced calls to begin/end appearance transitions for <UINavigationController: 0x7ff26305f600>.

Contributor guide

Research direction
Investigate the drawer opening animation code. Look for initial frame or layout issues that cause vertical animation on first display. Check if the drawer view controller's view is properly laid out before animation begins. Examine the setDrawerState:animated: method and any associated layout logic.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftiOS Development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60