`TrustedHostsNetworkResolver` - add `by` support

Open
#9 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
30/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
php
Domain
networking

Research direction

Start in TrustedHostsNetworkResolver::process(), at the REMOTE_ADDR lookup shown in the issue. First determine what “by” support means from the repository’s existing resolver conventions, then identify the relevant tests or entry points. Done means the intended “by” behavior is implemented and covered by tests.

Written by the indexing model from the issue text.

Description

status:under discussion type:enhancement

In process(), here :

$actualHost = $request->getServerParams()['REMOTE_ADDR'] ?? null;
Dominant language
PHP
Stars
8
Forks
2
Avg merge
17h 16m
Merged PRs (30d)
3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from yiisoft/proxy-middleware

All issues in yiisoft/proxy-middleware

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.