Add optional `$clock` parameter to `CookieCollection::fromResponse()`
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
Research direction
Start with CookieCollection::fromResponse() and trace its call to Cookie::fromCookieString(). Add the optional clock parameter and ensure it is passed through; done means callers can provide a clock without breaking existing calls and the relevant tests pass.
Written by the indexing model from the issue text.
Description
It needs to pass clock to Cookie::fromCookieString().
- Dominant language
- PHP
- Stars
- 21
- Forks
- 5
- Avg merge
- 1h 7m
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from yiisoft/cookies
-
status:ready for adoption
Difficulty 3/5 1-2 days Newbie friendliness 72/100
Similar issues
-
priority: p3
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
googleapis/librarian#7636 ·
-
0. Needs triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nextcloud/fulltextsearch#1011 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
phpstan/phpstan-doctrine#794 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Automattic/static-site-importer#1767 ·