Make filters optional?
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
Research direction
Start in src/Classifier.php around lines 75-77, linked from the issue, and trace how the classifier handles an empty filter set. Define the expected result for a call with no filters, then verify that it returns all classes without changing filtered searches.
Written by the indexing model from the issue text.
Description
Should we return all classes if no filters are used?
https://github.com/yiisoft/classifier/blob/16b0d8aaa2b4b1f435ccb2b087f2a52e5e43be22/src/Classifier.php#L75-L77
- Dominant language
- PHP
- Stars
- 8
- Forks
- 3
- Avg merge
- 1h 8m
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Similar issues
-
tooling
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
UX
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
ProfessionalWiki/NeoWiki#1525 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
OpenConext/OpenConext-engineblock#2122 ·
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Automattic/safe-publish#594 ·