yhat/rodeo

Rodeo doesn't include "Hide Rodeo" as a menu bar item (OS X)

Open

#377 opened on Jul 14, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (3,934 stars) (473 forks)batch import
enhancementhelp wanted

Description

"Hide [application]" is a pretty standard feature on apps in OS X, with the system-wide default keyboard shortcut being "cmd-h".

Is it possible to include this in Rodeo? It doesn't seem like this keyboard shortcut is attached to any other commands at this time.

Contributor guide

Tech stack
pythonjavascript
Domain
frontenddesktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of menu barsFamiliarity with Electron's menu APIAccess to macOS for testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The menu bar is likely implemented in the main process, such as in `main.js` or similar file. Look for existing menu construction and add a 'Hide Rodeo' entry with the standard keyboard shortcut Cmd+H. Ensure the shortcut is not already bound by checking existing menu items. Refer to Electron's documentation for `Menu` and `MenuItem` to implement the hide behavior. Test the change on macOS to verify functionality.