yegor256/takes

Refactor TkHtmlTest to improve structure and edge case coverage (relates to #1408)

Open

#1,435 opened on Jul 24, 2025

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (215 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (875 stars)
PR merge metrics
 (Avg merge 95d 2h) (22 merged PRs in 30d)

Description

Improve and Refactor TkHtmlTest for Maintainability and Coverage (related to #1408)

The current implementation of TkHtmlTest can be improved in the following ways:

  1. Duplication: Each test manually builds a nearly identical expected response using Joined(..., body). This can be extracted into a helper method or reused variable.

  2. Edge Cases Missing:

    • No tests for null or empty input.
    • No assertion that Content-Type and Content-Length headers are semantically correct (not just matched by string).

  3. Structure Validation:

    • Could add a test to verify that the body actually starts/ends with <html> tags to ensure semantic HTML is passed.

  4. Test Readability:

    • Introduce @DisplayName annotations or comment grouping to make intent clearer.

A can provide a PR if the maintainers agree.

Contributor guide

Research direction
Inspect the existing TkHtmlTest class, see how it builds expected responses with Joined, and identify duplication. Look for edge cases such as null or empty input and verify that Content Type and Content Length headers are semantically correct. Consider adding @DisplayName annotations to clarify test intent.
Tech stack
java
Domain
backendtesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaMavenJUnit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75