yegor256/factbase

Security concern: It's very dangerous to use `Marshal.load` with untrusted data.

Open

#106 opened on Jul 24, 2024

View on GitHub
 (11 comments) (0 reactions) (0 assignees)Ruby (17 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (19 stars)
PR merge metrics
 (PR metrics pending)

Description

See security recommendations for details.

It's used in baza. As far as I understand the code, the data was received from an HTTP request, which makes the data untrusted.

https://github.com/yegor256/factbase/blob/51d357c5d3c7411191a43c0184e0f43adba53e78/lib/factbase.rb#L218

Contributor guide

Research direction
Examine the usage of Marshal.load in front push.rb and factbase.rb. Understand the data flow from HTTP requests. Research safe deserialization alternatives like JSON or using a sandboxed Marshal.
Tech stack
ruby
Domain
backendsecurity
Issue type
Security
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RubyMarshal
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50