yarolegovich/DiscreteScrollView

Dependent on size of first item in adapter

Open

#20 opened on May 10, 2017

View on GitHub
 (10 comments) (23 reactions) (0 assignees)Java (5,728 stars) (768 forks)batch import
help wanted

Description

Problem : all list items take up the size of the first item in the adapter list - this is a terrible assumption for a generic library like this one!

My adapter has a header of toolbar height ?android:attr/actionBarSize and then a list variable length images - something like facebook's newsfeed. I ended up with a vertical stack of lots of items, all of the same toolbar height.

Is ther an easy fix to this? I haven't gone through the code yet, hence not aware of how much effort this would require.

Contributor guide

Tech stack
java
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaAndroid SDKAdapter pattern
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the library's adapter and layout logic, likely in Java files. The current implementation assumes all items have the same size as the first item. To fix, you need to modify the measurement logic to calculate each item's size individually. Look at how the library measures and lays out items, possibly in a custom LayoutManager or ViewHolder. Examine the comments in the issue for suggestions from other contributors.