yarnpkg/yarn

yarn should warn if a resolution appears to attempt to change a top level dependency

Open

#7320 opened on Jun 5, 2019

View on GitHub
 (18 comments) (0 reactions) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import
cat-featuregood first issue

Description

Do you want to request a feature or report a bug? feature request

What is the current behavior? Currently yarn why won't indicate any package info in the resolutions field

If the current behavior is a bug, please provide the steps to reproduce.

  1. install a package with any version, e.g "pkg": "^1.0.0"
  2. add resolutions field in package.json, pkg: "1.0.0"
  3. update "pkg": "^1.0.0" to "pkg": "^2.0.0" in deps
  4. run yarn why pkg

It only displays "pkg": "^2.0.0" being used, but no info about pkg: "1.0.0", while in yarn.lock, can find pkg: "1.0.0" related info

What is the expected behavior? expect to display resolutions package info as well

Please mention your node.js, yarn and operating system version. yarn: 1.16.0 macOS node: 8.16.0

Contributor guide

Tech stack
javascriptnodejs
Domain
clitooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Yarn's resolution algorithmFamiliarity with yarn why commandNode.js development setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
This issue requests that `yarn why` also display packages specified in the `resolutions` field of package.json. The 1.x line of Yarn is frozen; new features are being developed on Yarn Berry (https://github.com/yarnpkg/berry). To implement this, you would need to examine the resolution logic in the Yarn 1.x codebase, likely in files related to package resolution and the `why` command (e.g., `src/package resolver.js` or `src/cli/commands/why.js`). The community discussion (18 comments) may provide additional context on expected behavior and edge cases. Note that a fix for this feature should consider the frozen status and potentially be submitted to the Berry repository instead.