yarnpkg/yarn

yarn upgrade-interactive fails with Invalid version: undefined error if a dependency has only prerelease versions

Open

#5955 opened on Jun 8, 2018

View on GitHub
 (8 comments) (0 reactions) (1 assignee)JavaScript (41,514 stars) (2,731 forks)batch import
cat-buggood first issuehelp wanted

Description

Do you want to request a feature or report a bug? A bug

What is the current behavior? When running yarn upgrade-interactive and a dependency does not have a "latest" version then it fails with an error "Invalid version: undefined"

If the current behavior is a bug, please provide the steps to reproduce.

  • add a dependency that does not have a "latest" tag (only prerelease versions published with tag "beta")
  • run yarn upgrade-interactive

What is the expected behavior? The command should run successfully and show the upgradeable versions of all packages.

If the package in question has a later prerelease version, that version should be suggested to be upgraded to.

Please mention your node.js, yarn and operating system version.

Arguments: C:\Program Files (x86)\node\node.exe C:\Users\jens.elstner\AppData\Roaming\npm\node_modules\yarn\bin\yarn.js upgrade-interactive

Yarn version: 1.7.0

Node version: 8.11.1

Platform: win32 x64

Trace: TypeError: Invalid Version: undefined at new SemVer (C:\Users\jens.elstner\AppData\Roaming\npm\node_modules\yarn\lib\cli.js:2465:11) at SemVer.module.exports.SemVer.compare (C:\Users\jens.elstner\AppData\Roaming\npm\node_modules\yarn\lib\cli.js:2528:13) at compare (C:\Users\jens.elstner\AppData\Roaming\npm\node_modules\yarn\lib\cli.js:2752:31) at Function.lt (C:\Users\jens.elstner\AppData\Roaming\npm\node_modules\yarn\lib\cli.js:2786:10) at isDepOld (C:\Users\jens.elstner\AppData\Roaming\npm\node_modules\yarn\lib\cli.js:36817:134) at Array.filter () at Function. (C:\Users\jens.elstner\AppData\Roaming\npm\node_modules\yarn\lib\cli.js:36822:19) at Generator.next () at step (C:\Users\jens.elstner\AppData\Roaming\npm\node_modules\yarn\lib\cli.js:98:30) at C:\Users\jens.elstner\AppData\Roaming\npm\node_modules\yarn\lib\cli.js:109:13

Contributor guide

Tech stack
javascriptnodejs
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
understanding of semverfamiliarity with yarn's upgrade interactive flowJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The error occurs in the `isDepOld` function in the CLI code (around line 36817 in the trace). It assumes a 'latest' version exists. For packages with only prerelease tags, the latest version is undefined, causing the SemVer constructor to throw. The fix should handle missing 'latest' by falling back to the highest version available (e.g., from dist tags) or by filtering out packages without a valid latest version. Files to modify: likely in the upgrade interactive module. No linked PRs exist; the assignee may need to be consulted, but the issue is stale.