yarnpkg/yarn

Yarn publish reports success despite request failing

Open

#5,931 opened on Jun 5, 2018

View on GitHub
 (2 comments) (6 reactions) (1 assignee)JavaScript (41,514 stars) (2,731 forks)batch import
cat-bughelp wantedhigh-priority

Description

Do you want to request a feature or report a bug? bug

What is the current behavior? When running yarn publish, Yarn reports success Published. after having a 400 error code returned on the PUT request

If the current behavior is a bug, please provide the steps to reproduce. The registry is returning 400 on the PUT request. I'm not sure at this time why our registry is returning a 400.

What is the expected behavior? The command should report back to the user that the publishing was not successful.

Please mention your node.js, yarn and operating system version. node v9.11.1 yarn v1.7.0 OS Ubuntu 18.04

image

Contributor guide

Tech stack
javascript
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsyarn internalsHTTP client handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the publish command flow in yarn, particularly the handling of HTTP responses when making PUT requests to the registry. Look at the code that prints the success message after a publish attempt. The issue suggests that a 400 error from the registry is not being properly propagated, leading to a misleading success message. Check the source files under src/cli/commands/publish.js or similar, and trace the response handling after the PUT request. Consider how the registry URL is constructed and whether error codes are checked.