yarnpkg/yarn

CLI switch "--scripts-prepend-node-path" doesn't work

Open

#5776 opened on May 3, 2018

View on GitHub
 (7 comments) (0 reactions) (1 assignee)JavaScript (41,514 stars) (2,731 forks)batch import
cat-buggood first issuehelp wanted

Description

Do you want to request a feature or report a bug? Bug

What is the current behavior? Using the --scripts-prepend-node-path switch seems not to do anything.

$ /myNodePath/bin/node myYarnPath/bin/yarn.js run --scripts-prepend-node-path env

Running this outputs an "env" without myNodePath in the "PATH".

{
  "NODE": "/myNodePath/bin/node",
  ...
  "PATH": "/myProject/node_modules/.bin:/Users/jdevine/.config/yarn/link/node_modules/.bin:/myProject/node_modules/.bin:/myProject/node_modules/.bin:/Users/jdevine/.config/yarn/link/node_modules/.bin:/myProject/node_modules/.bin:/myNodePath/libexec/lib/node_modules/npm/bin/node-gyp-bin:/myNodePath/lib/node_modules/npm/bin/node-gyp-bin:/myNodePath/bin/node_modules/npm/bin/node-gyp-bin:/usr/local/sbin:/usr/local/bin:/Users/jdevine/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin",
  ...

We would expect that the node path (/myNodePath/bin) be the first thing in the PATH in the env. In fact, if I comment out the config check in yarn:

//    if (config.scriptsPrependNodePath) {
      pathParts.unshift(path.join(path.dirname(process.execPath)));
//    }

If I make that change, then see what I expect - the path includes /myNodePath/bin, and my install scripts, and "yarn run" scripts work as expected.

{
  "NODE": "/myNodePath/bin/node",
  ...
  "PATH": "/myNodePath/bin/:/myProject/node_modules/.bin:/Users/jdevine/.config/yarn/link/node_modules/.bin:/myProject/node_modules/.bin:/myProject/node_modules/.bin:/Users/jdevine/.config/yarn/link/node_modules/.bin:/myProject/node_modules/.bin:/myNodePath/libexec/lib/node_modules/npm/bin/node-gyp-bin:/myNodePath/lib/node_modules/npm/bin/node-gyp-bin:/myNodePath/bin/node_modules/npm/bin/node-gyp-bin:/usr/local/sbin:/usr/local/bin:/Users/jdevine/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin",
  ...

If the current behavior is a bug, please provide the steps to reproduce. This reproduces every time.

What is the expected behavior? As above. We expect that using --scripts-prepend-node-path should prepend the node path to the PATH in the environment when scripts are executed at install time and run time.

Please mention your node.js, yarn and operating system version. node v8.10.0 yarn v1.6.0

Contributor guide

Tech stack
javascriptnodejs
Domain
clitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic understanding of yarn's codebaseNode.js path handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue is a bug where the scripts prepend node path CLI flag does not prepend the node path to PATH. The bug is reproducible and the reporter identifies that the config check at line (likely in src/util/execute lifecycle script.js or similar) is preventing the path prepend. The fix involves removing or correcting the if condition that checks config.scriptsPrependNodePath. Since the repository is frozen (1.x line), any fix should be directed to the berry repository. A newcomer should locate the exact file, confirm the logic, and ensure the flag works as expected.