yarnpkg/yarn

"yarn upgrade --latest" fails if optionalDependencies contains incompatible dependencies

Open

#5,471 opened on Mar 7, 2018

View on GitHub
 (0 comments) (0 reactions) (1 assignee)JavaScript (41,514 stars) (2,731 forks)batch import
cat-bughelp wantedtriaged

Description

Do you want to request a feature or report a bug?

Bug

What is the current behavior? If optionalDependencies contains packages incompatible with current platform, upgrading fails with error "Found incompatible module".

If the current behavior is a bug, please provide the steps to reproduce.

Work under win32 platform:

  1. Create package.json:
{
  "name": "yarn-example",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "optionalDependencies": {
    "fsevents": "1.0.0",
    "chokidar": "2.0.0"
  },
  "private": true
}
  1. Run yarn install
  2. Run yarn upgrade --latest

What is the expected behavior?

Incompatible dependencies are skipped during upgrade

Please mention your node.js, yarn and operating system version.

node 8.9.3 yarn 1.5.1 OS Windows 8.1

Contributor guide

Tech stack
javascriptnodejs
Domain
clitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of yarn CLIUnderstanding of package.json dependencies
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
The issue is about `yarn upgrade latest` failing when optionalDependencies contain platform incompatible packages. The bug is clear from the reproduction steps. The fix likely involves modifying the upgrade command to skip incompatible optional dependencies rather than throwing an error. Relevant source files are in `src/cli/commands/upgrade.js` or the dependency resolution logic. Since the yarn 1.x repository is frozen, any contribution would be for legacy support; consider also checking if the issue exists in berry (yarn 2+).