yarnpkg/yarn

`yarn add --cwd invalid-dir` should warn/fail

Open

#5206 opened on Jan 10, 2018

View on GitHub
 (5 comments) (0 reactions) (1 assignee)JavaScript (41,514 stars) (2,731 forks)batch import
cat-featuregood first issuehelp wantedtriaged

Description

Do you want to request a feature or report a bug?

Bug

What is the current behavior? yarn add --cwd invalid-dir bluebird installs bluebird to the root:

yarn add v1.3.2
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency.
└─ bluebird@3.5.1
✨  Done in 0.30s.

If the current behavior is a bug, please provide the steps to reproduce.

Just yarn add --cwd invalid-dir bluebird (and invalid-dir not exist, of course)

What is the expected behavior? Throw an error, or at least show a warning.

For reference, on npm 5.6.0, npm --prefix invalid-dir bluebird creates invalid-dir and installs it there (which I also think is unexpected behavior), but at least it throws a warning:

$ npm i --prefix invalid-dir bluebird
npm WARN saveError ENOENT: no such file or directory, open '/Users/marvin/devel/yarn-add-cwd-demo/invalid-dir/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN enoent ENOENT: no such file or directory, open '/Users/marvin/devel/yarn-add-cwd-demo/invalid-dir/package.json'
npm WARN invalid-dir No description
npm WARN invalid-dir No repository field.
npm WARN invalid-dir No README data
npm WARN invalid-dir No license field.

+ bluebird@3.5.1
added 1 package in 0.734s

Please mention your node.js, yarn and operating system version. node v8.9.4, yarn 1.3.4, macOS High Sierra 10.13.2

Contributor guide

Tech stack
javascriptnodejs
Domain
clideveloper experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript basicsYarn CLI concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the handling of cwd flag in yarn's CLI. The fix likely requires validating that the directory exists before proceeding with the install. Look at the source files related to argument parsing, possibly src/cli/index.js or similar. The error should be thrown early with a clear message. No linked PRs or comments indicate prior work.