yarnpkg/yarn

Yarn ignores no_proxy environment variable when proxy property set

Open

#5,048 opened on Dec 6, 2017

View on GitHub
 (33 comments) (24 reactions) (1 assignee)JavaScript (41,514 stars) (2,731 forks)batch import
cat-compatibilitycat-featurehelp wantedtriaged

Description

Do you want to request a feature or report a bug? Both

What is the current behavior? If proxy and http-proxy are set, NO_PROXY and no_proxy environment variables are ignored.

If the current behavior is a bug, please provide the steps to reproduce.

  1. Set proxy and https-proxy config and can find from yarn config list
...
info npm config
{ proxy: 'http://some.proxy.host:8080/',
  'https-proxy': 'http://some.proxy.host:8080/',
...
  1. Set NO_PROXY or no_proxy environment variable like $ no_proxy="some.url.private.repo"
  2. Run yarn install
  3. proxy and https-proxy work but no_proxy environment variable is ignored.

What is the expected behavior? NO_PROXY or no_proxy environment variable is applied.

Please mention your node.js, yarn and operating system version. Ubuntu 16.04 yarn 1.3.2

Contributor guide

Tech stack
javascriptnodejs
Domain
backendcli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with Node.js networkingunderstanding of environment variables
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate how Yarn currently applies proxy settings from config and environment variables. Look at the code that reads 'proxy' and 'https proxy' config values and the logic that checks 'no proxy' / 'NO PROXY' environment variable. The issue indicates that when proxy is set via config, the no proxy env variable is ignored. Identify the specific file and function where proxy resolution occurs (likely in src/util/network.js or similar). Check if there is an existing utility to parse no proxy. Consider adding a check for no proxy before applying the proxy agent.