yarnpkg/yarn

Fix code duplications in the repo

Open

#4950 opened on Nov 17, 2017

View on GitHub
 (9 comments) (0 reactions) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import
cat-choregood first issuehelp wantedtriaged

Description

We have recently introduced js-inspect with the command yarn dupe-check which reports 21 matches even with relaxed settings. It would be great to clear these duplicate code pieces out.

Contributor guide

Tech stack
javascriptnodejs
Domain
tooling
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Running yarn commandsBasic JavaScript knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Run 'yarn dupe check' to identify the 21 duplicated code matches. Review the reported files and refactor to eliminate duplication while preserving functionality. Check the issue comments for any prior discussion or suggestions on how to approach specific duplicates.