yarnpkg/yarn

Scope deprecated dependency package's dir not be removed correctly

Open

#4,933 opened on Nov 15, 2017

View on GitHub
 (0 comments) (1 reaction) (1 assignee)JavaScript (41,514 stars) (2,731 forks)batch import
cat-bughelp wantedtriaged

Description

Report bug.

First My project's package.json:

"dependencies": {
    "@yunke/core": "^4.0.1",
    "@yunke/pc_navigation": "1.0.0",
}

@yunke/pc_navigation package.json :

"version": "1.0.0",
"dependencies": {
    "@yunke/core": "^3.5.5"
}

project's node_modules struct is ok:

node_modules
|--@yunke
    |--core //4.0.1
    |--pc_navigation
        |--node_modules
            |--@yunke
                 |--core //3.5.5

then update @yunke/pc_navigation to 1.0.1,

"version": "1.0.1",
"dependencies": {
    "@yunke/core": "^4.0.1"
}

and update project dependency,

"dependencies": {
    "@yunke/core": "^4.0.1",
    "@yunke/pc_navigation": "1.0.1",
}

use yarn or yarn --force, the project node_modules' struct still not change:

node_modules
|--@yunke
    |--core //4.0.1
    |--pc_navigation
        |--node_modules
            |--@yunke
                 |--core //3.5.5

expect

node_modules
|--@yunke
    |--core //4.0.1
    |--pc_navigation

node version: v8.2.1 yarn version: 1.3.2 OS: mac, linux

Contributor guide

Tech stack
javascriptnodejs
Domain
build systemdeveloper experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic JavaScript and Node.jsUnderstanding of Yarn package managerFamiliarity with npm/yarn dependency resolutionExperience with node modules structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
The issue reports that Yarn fails to remove the nested `@yunke/core` directory when a scoped dependency's version is updated. Investigate the Yarn source code, particularly `src/package resolver.js` and `src/install.js`, to understand how dependency pruning and hoisting work for scoped packages. Look for existing tests and consider if the algorithm for cleaning up nested `node modules` needs improvement. A fix would likely involve updating the logic that determines which packages to remove after a dependency change.