yarnpkg/yarn

`upgrade-interactive` always shows dependency installed via Git as outdated

Open

#4896 opened on Nov 10, 2017

View on GitHub
 (8 comments) (2 reactions) (1 assignee)JavaScript (41,514 stars) (2,731 forks)batch import
cat-buggood first issuehelp wantedtriaged

Description

When running the following in an empty directory:

yarn init
yarn add https://github.com/timm-gs/pixelmatch
yarn upgrade-interactive

What is the current behavior?

Yarn shows the just added package as outdated. Same behavior on future attempts after upgrading. (Does not change yarn.lock)

What is the expected behavior?

I would expect yarn to know that the package / Git repo did not change and hence not offer to upgrade it.

Please mention your node.js, yarn and operating system version.

$ git --version
git version 2.15.0

$ node -v
v6.12.0

$ yarn -v
1.3.2

$ uname -a
Darwin MacBook-Pro.local 16.7.0 Darwin Kernel Version 16.7.0: Wed Oct  4 00:17:00 PDT 2017; root:xnu-3789.71.6~1/RELEASE_X86_64 x86_64

Contributor guide

Tech stack
javascriptnodejs
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the `upgrade interactive` command logic in the yarn codebase (likely in `src/cli/commands/upgrade interactive.js` or similar). The bug is that git installed dependencies always appear as outdated because the version comparison does not account for the git reference (commit SHA or branch). Focus on how the current version is determined for git dependencies and compare with the requested version. Check if there are any related tests or prior discussions in the issue comments (#4896) that provide additional context. The fix may involve comparing the resolved commit hash or using the git URI itself as version.