yarnpkg/yarn

Inconsistent config strings

Open

#4496 opened on Sep 18, 2017

View on GitHub
 (9 comments) (0 reactions) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import
cat-featuregood first issuehelp wantedtriaged

Description

Continuation from #4457

Do you want to request a feature or report a bug? Potential bug.

What is the current behavior? Yarn config has different formatting for object keys that are computed / set vs defaults.

I'm not sure I understand if this is by design or not. If so, what is the use case?

Initial registry configuration

What is the expected behavior? Keys should all be wrapped in single quotes or DEFAULTS should follow same formatting as registry, lastUpdateCheck, and user configured values do

Please mention your node.js, yarn and operating system version. Yarn: 1.0.2 Node: 8.1.4

Happy to submit a PR if the current functionality isn't as expected.

Contributor guide

Tech stack
javascript
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Fix the inconsistency in formatting of config keys in src/registries/yarn registry.js, where default keys are not wrapped in single quotes while others are. Ensure all keys use the same quoting style. See issue #4457 for prior discussion.