yarnpkg/yarn

File dependencies from transitive dependencies are stored incorrectly in lock file

Open

#4,388 opened on Sep 11, 2017

View on GitHub
 (18 comments) (17 reactions) (1 assignee)JavaScript (41,514 stars) (2,731 forks)batch import
cat-bughelp wantedhigh-prioritytriaged

Description

What is the current behavior?

When having a file dependency that has more file dependencies, these second-level dependencies are referenced in cache, e.g.:

{
  name: "x"
  dependencies: {
    "a": "file:../../a"
  }
}

with:

{
  name: "a",
  dependencies: {
    "b": "../b"
  }

would result in a lock entry like:

 "a@file:../../a":
   dependencies:
     "b" "file:../../../../../Library/Caches/Yarn/v1/npm-b"

instead of (yarn 0.27.5):

 "a@file:../../a":
   dependencies:
     "b" "file:../b"

If the current behavior is a bug, please provide the steps to reproduce.

Create two chains of dependencies, see: https://github.com/joscha/yarn-101-links especially https://github.com/joscha/yarn-101-links/blob/master/my-package/yarn.lock#L8

What is the expected behavior? Have relative links only, so the whole node_modules folder can be gzipped.

Please mention your node.js, yarn and operating system version. node: 8.4.0 yarn 1.0.1 OSX Sierra

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingcli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of YarnUnderstanding of lock files
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate how Yarn resolves file dependencies in lock files. The issue references a reproduction repo at https://github.com/joscha/yarn 101 links. Start by examining the lock file generation logic in the Yarn source code, particularly how transitive file dependencies are cached and resolved. Look at the linked PRs or comments for any attempted fixes. Since the issue is assigned, check if the assignee has any pending work.