yarnpkg/yarn

Workspaces don't run lifecycle scripts when linking local packages

Open

#3911 opened on Jul 11, 2017

View on GitHub
 (36 comments) (59 reactions) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import
cat-buggood first issuehelp wantedhigh-prioritytriaged

Description

What is the current behavior?

When you do a yarn install in a workspaces enabled project, yarn doesn't run the various lifecycle scripts for workspace packages, e.g. prepare prepublish preinstall etc

If the current behavior is a bug, please provide the steps to reproduce.

Here is a commit adding a failing test case: https://github.com/jquense/yarn/commit/61eaf4239f707f772af5713ebc98963589a6dad4

What is the expected behavior?

Lifecycle scripts are run for the local packages so they have an opportunity to build steps. This is what lerna does.

Please mention your node.js, yarn and operating system version.

yarn 27.5 node 8 Mac Sierra

cc @bestander

Contributor guide

Tech stack
javascript
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
understanding of yarn workspacesknowledge of npm lifecycle scriptsfamiliarity with yarn's codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Review the failing test at https://github.com/jquense/yarn/commit/61eaf4239f707f772af5713ebc98963589a6dad4 to understand expected behavior. Examine yarn's workspace linking logic in the source code, specifically where lifecycle scripts should be called for linked packages. Compare with lerna's approach in BootstrapCommand. Since yarn 1.x is frozen, consider if the fix should be proposed for the berry repository.