yarnpkg/yarn

Packages with build artifacts missing, but listed in .yarn-integrity, should be rebuilt.

Open

#3781 opened on Jun 30, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import
cat-buggood first issuehelp wantedtriaged

Description

Do you want to request a feature or report a bug? Bug

What is the current behavior?

Packages are not rebuilt if all non-build artifacts already exist at the destination. This results in errors like:

module.js:327
    throw err;
    ^

Error: Cannot find module '../build/Release/hash'
    at Function.Module._resolveFilename (module.js:325:15)
    at Function.Module._load (module.js:276:25)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/.../node_modules/xxhash/lib/xxhash.js:4:13)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)

If the current behavior is a bug, please provide the steps to reproduce.

$ yarn add xxhash
$ rm node_modules/xxhash/build/Release/hash.node
// Bring in an updated yarn.lock (i.e., via git)
$ yarn 
// xxhash does not get rebuilt

What is the expected behavior?

If a file contained in .yarn-integrity is missing (or maybe even the wrong size or mtime), the package should be rebuilt.

Please mention your node.js, yarn and operating system version.

node@4.8.2 yarn@master:HEAD (69574f6a695a4184d349876ff196905e7fb992be) Docker ubuntu12.04

Related: https://github.com/yarnpkg/yarn/issues/231 https://github.com/yarnpkg/yarn/issues/1955#issuecomment-293728671 https://github.com/yarnpkg/yarn/issues/1955#issuecomment-296745770

Contributor guide

Tech stack
javascriptnodejs
Domain
clibuild system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptYarn internalsbuild lifecycle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the logic in Yarn's installer that checks .yarn integrity to determine if a package needs rebuilding. The issue arises when build artifacts (e.g., hash.node) are missing but non build artifacts exist, causing the integrity check to pass incorrectly. Look at the relevant code files, such as those handling package installation and build steps, and examine the related issues (#231, #1955) for context. The fix would involve ensuring that missing build artifacts trigger a rebuild even if other files are present.