yarnpkg/yarn

Yarn missing python flag

Open

#3519 opened on May 29, 2017

View on GitHub
 (8 comments) (17 reactions) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import
cat-compatibilitygood first issuehelp wantedtriaged

Description

Do you want to request a feature or report a bug? Feature request

What is the current behavior? yarn add x --python=2.7 ignores the flag.

What is the expected behavior? Yarn should use the specified version of python when building modules since npm does. Yarn should also check the python flag set in the npm config for example running this command doesn't change the python version being used. npm config set python python2.7

Ref: https://github.com/trentm/node-bunyan/issues/216#issuecomment-304639731

Please mention your node.js, yarn and operating system version. N/A

Contributor guide

Tech stack
javascriptnodejs
Domain
clibuild system
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptNode.jsyarn project setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate how yarn currently handles npm config and the python flag. Look at the command parsing in src/cli/commands/install.js and the python detection logic in src/util/find python.js. Check if the feature exists in yarn 2.x (berry) to avoid duplicate effort. Review the linked bunyan issue for context on expected behavior. The goal is to make yarn pass the specified python version to node gyp when building native modules.