yarnpkg/yarn

Yarn does not symlink missing binaries

Open

#3421 opened on May 16, 2017

View on GitHub
 (16 comments) (14 reactions) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import
cat-bugcat-compatibilitygood first issuehelp wantedhigh-prioritytriaged

Description

What is the current behavior? When you npm install a package like sentry-cli-binary the postinstall step will download a platform specific executable and put it into the bin folder. With yarn the symlink is not generated because the file does not exist yet.

If the current behavior is a bug, please provide the steps to reproduce. Make a dependency to sentry-cli-binary and observe that yarn does not install the symlink for the binary whereas npm does.

What is the expected behavior? The same behavior that npm shows.

Versions tested

$ yarn --version
0.24.4
$ npm --version
4.2.0

Contributor guide

Tech stack
javascriptnodejs
Domain
clideveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsYarnnpm postinstall scripts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the Yarn source code, specifically the package install logic that handles binary symlinks. Look at the npm implementation for comparison. Check if there is a race condition with postinstall scripts. Review comments in the issue for any proposed solutions or workarounds. Files to examine: src/package install.js or similar.