yarnpkg/yarn

Should not copy `node_modules` of `file:` dependencies

Open

#3344 opened on May 7, 2017

View on GitHub
 (5 comments) (4 reactions) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import
cat-buggood first issuehelp wantedhigh-prioritytriaged

Description

0.23.4 When we do yarn add file:..path yarn should copy existing contents of node_modules, currently it copies it to cache as well.

Contributor guide

Tech stack
javascriptnodejs
Domain
build systembackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptNode.js modulesYarn internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate how Yarn handles 'file:' protocol dependencies in its caching mechanism. Look at the source files related to package fetching and caching, such as 'src/package fetcher.js' and 'src/package cache.js'. Identify where the node modules directory is copied during the add process and determine the condition that should exclude copying for 'file:' dependencies. The issue mentions version 0.23.4, so check the codebase at that tag for relevant logic. No existing PRs or comments provide further direction.