yarnpkg/yarn

Error adding remote tarball package

Open

#3,160 opened on Apr 15, 2017

View on GitHub
 (4 comments) (1 reaction) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import
cat-bugcat-documentationgood first issuehelp wantedtriaged

Description

Do you want to request a feature or report a bug? Report a bug

What is the current behavior?

When adding a remote tarball package an error occurs:

error An unexpected error occurred: "https://github.com/blikblum/cherrytree/releases/download/svelte-2.4.2/build.tar.gz: EISDIR: illegal operation on a directory, open '/home/luiz/.cac he/yarn/v1/.tmp/9417ab587e459fe380a7e913f4160254/'".

If the current behavior is a bug, please provide the steps to reproduce.

In an empty folder:

yarn init // create a dummy project yarn add https://github.com/blikblum/cherrytree/releases/download/svelte-2.4.2/build.tar.gz

Manually updating dependencies in package.json like

dependencies: {
 "cherrytree": "https://github.com/blikblum/cherrytree/releases/download/svelte-2.4.2/build.tar.gz"
}

and doing yarn install the error also occurs

What is the expected behavior? Package from link https://github.com/blikblum/cherrytree/releases/download/svelte-2.4.2/build.tar.gz should be installed and added to dependencies

Please mention your node.js, yarn and operating system version. Yarn 0.23.2 Node 6.10 Linux Mint 17.3 and Windows 10

Contributor guide

Tech stack
javascriptnodejs
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.js streamsYarn internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Research the tarball download and extraction logic in the Yarn codebase. The EISDIR error indicates that an attempt was made to open a directory as a file during extraction. Focus on the extractor functions, likely in `src/util/fs.js` or `src/package installer.js`. Check if there is a missing check for whether the target path is a directory before attempting to write. Review any existing tests for remote tarball additions to see if this case is covered.