yarnpkg/yarn

Yarn install shell script uninstalls before successful download

Open

#2,808 opened on Feb 28, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import
cat-buggood first issuehelp wantedhigh-prioritytriaged

Description

Do you want to request a feature or report a bug? Likely a bug.

What is the current behavior? Yarn will prompt you to update if it sees the version you are using is behind the current release. In my case, because I installed with the install.sh script, it prompts me to do so again. However, if the file it attempts to download is unavailable (say, during the S3 apocalypse of 2017), the install will fail. But because it has already removed $HOME/.yarn, it leaves the user without even their older Yarn installation.

If the current behavior is a bug, please provide the steps to reproduce. I'm not sure... you would have to recreate a scenario where the Yarn site is live, but the package is not.

What is the expected behavior? Ideally, it would not blow away the current Yarn installation before it successfully downloads the latest version.

Please mention your node.js, yarn and operating system version. Node.js: v6.9.4 Yarn: 0.20.3 (attempting to move to 0.21.3) OS: MacOS Sierra 10.12.3

Contributor guide

Tech stack
shellnodejs
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic shell scriptingUnderstanding of Yarn install script
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the install.sh script (likely in the repository root) to understand the update flow. Currently, the script removes the existing $HOME/.yarn directory before downloading the new version. Modify the script to download the new version first and only remove the old installation after a successful download. Ensure error handling so that if download fails, the previous installation remains intact. Refer to comments in the issue about the S3 outage scenario.