yarnpkg/yarn

Use shortand for gitlab dependencies

Open

#2,774 opened on Feb 24, 2017

View on GitHub
 (11 comments) (9 reactions) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import
cat-featuregood first issuehelp wantedtriaged

Description

What is the current behavior? yarn add "gitlab:mygitlabuser/myproject"

gives an error

What is the expected behavior?

Should behave the same as
npm install -S "gitlab:mygitlabuser/myproject"

With npm this is a valid dependency also in package.json, while it doesn't work with yarn. This is actually a simple shorthand for a complete git url and work the same for bitbucket and gist

Please mention your node.js, yarn and operating system version. node v7.6.0 on Kde Neon (linux 4.4.0-64-generic)

Contributor guide

Tech stack
javascriptnodejs
Domain
clideveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptYarn dependency parsingGitLab shorthand syntax
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate how Yarn currently resolves git dependencies, likely in the resolver or git utility files (e.g., src/util/git.js). Compare with npm's implementation of 'gitlab:' shorthand. The issue comments may provide additional context. Implement parsing logic to recognize 'gitlab:' shorthand as a valid dependency specification.