yarnpkg/yarn

Yarn Link doesn't support path to match npm

Open

#1,100 opened on Oct 15, 2016

View on GitHub
 (2 comments) (5 reactions) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import
cat-featurehelp wantedneeds-discussiontriaged

Description

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

kstone@kstone-mbp $PWD> yarn link .
yarn link v0.15.1
error Couldn't find a package.json (or bower.json) file in $HOME/.yarn-cache/.link
[...]

kstone@kstone-mbp $PWD> yarn link 
yarn link v0.15.1
success Registered "$PKG".
info You can now run `yarn link "$PKG"` in the projects where you want to use this module and it will be used instead.
✨  Done in 0.06s.

If the current behavior is a bug, please provide the steps to reproduce.

See above.

What is the expected behavior?

kstone@kstone-mbp $PWD> npm link .
[...]
/usr/local/lib/node_modules/$PKG -> $PWD

Please mention your node.js, yarn and operating system version.

kstone@kstone-mbp $PWD> node --version
v6.8.1
kstone@kstone-mbp $PWD> yarn --version
0.15.1
kstone@kstone-mbp $PWD> sw_vers 
ProductName:    Mac OS X
ProductVersion: 10.12
BuildVersion:   16A319

Contributor guide

Tech stack
nodejsjavascript
Domain
clideveloper experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of Yarn CLIFamiliarity with symlinks and package linking
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requests adding path support to `yarn link`, mirroring `npm link .` behavior. The current implementation only links the current package by name. To fix, examine the `link` command in `src/cli/commands/link.js`. The expected behavior is that `yarn link .` should symlink the local package directory to the global node modules. Look for how npm implements this; likely using `fs.symlink`. The discussion in the issue and linked PRs may provide hints.