yangshun/front-end-interview-handbook

element with display flex do not create a new BFC itself

Open

#159 opened on Jan 15, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (37,729 stars) (5,420 forks)batch import
help wanted

Description

In CSS section, the answer says "A BFC is an HTML box that satisfies at least one of the following conditions: ... The value of display is table-cell, table-caption, inline-block, flex, or inline-flex."

display flex create a new flex formatting context, not block formatting context. Only flex items (its children) create new BFC.

Contributor guide

Tech stack
css
Domain
frontenddocumentation
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
understanding of CSS formatting contexts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue points out an error in the CSS section of the front end interview handbook. The statement that display: flex creates a BFC is incorrect; it creates a flex formatting context. To fix, locate the relevant section in the repository's content files (likely in a markdown file under the CSS directory). Modify the text to indicate that flex and inline flex establish a flex formatting context, not a BFC. Also ensure that the note about flex items creating new BFCs is accurate.