yairEO/tagify

appendTarget hiding/selecting issues for shadowdom

Open

#1,390 opened on Oct 17, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)HTML (456 forks)github user discovery
Help wantedSuggestion

Repository metrics

Stars
 (3,880 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Prerequisites

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

💥 Demo Page

I can do it in some days, i need some time to build a simple lit element for this.

Explanation

  • What is the expected behavior?

There are a lot of document.body checks in the code which doesn't work in shadowdom. It should be the appendTarget element:

https://github.com/yairEO/tagify/blob/master/src/parts/dropdown.js#L155 https://github.com/yairEO/tagify/blob/master/src/parts/dropdown.js#L218

  • What is happening instead?

Checking in the document.body instead of appendTarget

  • What error message are you getting?

A lot of glitches.

Contributor guide

Research direction
Replace document.body references with appendTarget in dropdown.js lines 155 and 218 to fix shadow DOM issues.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptDOM
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70