yahoo/fluxible

[fluxible-router] case-sensitive routing

Open

#435 opened on Apr 27, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,816 stars) (233 forks)batch import
enhancementhelp wanted

Description

the routing in fluxible-router is case insensitive currently. i'd like to use case-sensitive routing..

it seems that fluxible-router uses routr, which in turn uses path-to-regexp, which has an option for this, but it's not possible to pass down this option to it.

basically this line https://github.com/yahoo/routr/blob/master/lib/router.js#L38 needs to get an additional {sensitive:true} param at the end.

what would be the best way to achieve this? (to be able to choose case-sensitive routing)

Contributor guide

Tech stack
javascriptnodejs
Domain
full stack
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptNode.jsRouting concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Investigate routr's router.js at line 38 to add the `{sensitive:true}` option. Check if routr has a way to pass options from fluxible router. Consult the path to regexp documentation for the sensitive flag. Consider adding a configuration option to fluxible router to enable case sensitive routing.