yahoo/fluxible

[fluxible-router] case-sensitive routing

Open

#435 opened on Apr 27, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (233 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (1,816 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

the routing in fluxible-router is case insensitive currently. i'd like to use case-sensitive routing..

it seems that fluxible-router uses routr, which in turn uses path-to-regexp, which has an option for this, but it's not possible to pass down this option to it.

basically this line https://github.com/yahoo/routr/blob/master/lib/router.js#L38 needs to get an additional {sensitive:true} param at the end.

what would be the best way to achieve this? (to be able to choose case-sensitive routing)

Contributor guide

Research direction
Investigate how fluxible router creates the routr instance and find where to pass the {sensitive: true} option from path to regexp. The change likely involves modifying the router creation to accept a sensitivity option and forwarding it to routr's constructor.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70